Skip to content

remove http cache for jwks #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 28, 2025
+0 −30
Merged

remove http cache for jwks #8198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
802bf24
remove http cache for jwks
vepatel Aug 27, 2025
1243b08
update snaps
vepatel Aug 27, 2025
f62650c
update template test
vepatel Aug 27, 2025
ab98f56
update template test
vepatel Aug 27, 2025
5784afb
Merge branch 'main' into chore/remove-redundant-cache-jwks
vepatel Aug 28, 2025
2100e81
Merge branch 'main' into chore/remove-redundant-cache-jwks
vepatel Aug 28, 2025
3e52eee
Merge branch 'main' into chore/remove-redundant-cache-jwks
vepatel Aug 28, 2025
0003e61
Merge branch 'main' into chore/remove-redundant-cache-jwks
vepatel Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/configs/version2/__snapshots__/templates_test.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,6 @@ upstream vs_default_cafe_coffee {
keepalive 16;
}

proxy_cache_path /var/cache/nginx/jwks_uri_cafe levels=1 keys_zone=jwks_uri_cafe:1m max_size=10m;

server {
listen 80;
Expand All @@ -1256,8 +1255,6 @@ server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
proxy_cache jwks_uri_cafe;
proxy_cache_valid 200 12h;
proxy_ssl_server_name on;
proxy_ssl_name sni.idp.spec.example.com;
proxy_pass_request_headers off;
Expand All @@ -1270,8 +1267,6 @@ server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
proxy_cache jwks_uri_cafe;
proxy_cache_valid 200 12h;
proxy_ssl_server_name on;
proxy_ssl_name sni.idp.spec.example.com;
proxy_pass_request_headers off;
Expand Down Expand Up @@ -1362,7 +1357,6 @@ upstream vs_default_cafe_coffee {
keepalive 16;
}

proxy_cache_path /var/cache/nginx/jwks_uri_cafe levels=1 keys_zone=jwks_uri_cafe:1m max_size=10m;

server {
listen 80;
Expand All @@ -1384,8 +1378,6 @@ server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
proxy_cache jwks_uri_cafe;
proxy_cache_valid 200 12h;
proxy_pass_request_headers off;
proxy_pass_request_body off;
proxy_set_header Host idp.spec.example.com;
Expand All @@ -1396,8 +1388,6 @@ server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
proxy_cache jwks_uri_cafe;
proxy_cache_valid 200 12h;
proxy_pass_request_headers off;
proxy_pass_request_body off;
proxy_set_header Host idp.route.example.com;
Expand Down
8 changes: 0 additions & 8 deletions internal/configs/version2/nginx-plus.virtualserver.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,6 @@ map $request_method $cache_purge_{{ replaceAll $l.Cache.ZoneName "-" "_" }} {
{{- end }}
{{- end }}

{{- with $s.JWKSAuthEnabled }}
proxy_cache_path /var/cache/nginx/jwks_uri_{{$s.VSName}} levels=1 keys_zone=jwks_uri_{{$s.VSName}}:1m max_size=10m;
{{- end }}

{{- if and $s.OIDC $s.OIDC.PKCEEnable }}
include oidc/oidc_pkce_supplements.conf;
{{- end }}
Expand Down Expand Up @@ -290,10 +286,6 @@ server {
internal;
proxy_method GET;
proxy_set_header Content-Length "";
{{- if .KeyCache }}
proxy_cache jwks_uri_{{ $s.VSName }};
proxy_cache_valid 200 12h;
{{- end }}
{{- with .JwksURI }}
{{- if .JwksSNIEnabled }}
proxy_ssl_server_name on;
Expand Down
12 changes: 0 additions & 12 deletions internal/configs/version2/templates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,12 +731,6 @@ func TestExecuteVirtualServerTemplateWithJWKSWithToken(t *testing.T) {
if !bytes.Contains(got, []byte("token=$http_token")) {
t.Error("want `token=$http_token` in generated template")
}
if !bytes.Contains(got, []byte("proxy_cache jwks_uri_")) {
t.Error("want `proxy_cache` in generated template")
}
if !bytes.Contains(got, []byte("proxy_cache_valid 200 12h;")) {
t.Error("want `proxy_cache_valid 200 12h;` in generated template")
}

if !bytes.Contains(got, []byte("proxy_ssl_server_name on;")) {
t.Error("want `proxy_ssl_server_name on;` in generated template")
Expand All @@ -760,12 +754,6 @@ func TestExecuteVirtualServerTemplateWithJWKSWithoutToken(t *testing.T) {
if bytes.Contains(got, []byte("token=$http_token")) {
t.Error("want no `token=$http_token` string in generated template")
}
if !bytes.Contains(got, []byte("proxy_cache jwks_uri_")) {
t.Error("want `proxy_cache` in generated template")
}
if !bytes.Contains(got, []byte("proxy_cache_valid 200 12h;")) {
t.Error("want `proxy_cache_valid 200 12h;` in generated template")
}
snaps.MatchSnapshot(t, string(got))
t.Log(string(got))
}
Expand Down