Skip to content

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

This commit updates the path for the volumeMounts shown in the NAP5 compile documentation to use the newest convention, and also adds a missing parameter from the kubectl cp example at the end of the page.

Issue reported by Fabrizio Fiorucci, as it can cause confusion and possible error for a reader following along and reading the NAP documentation concurrently.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

* Fix mountPath directory for NAP5 policy documentation

This commit updates the path for the volumeMounts shown in the NAP5
compile documentation to use the newest convention, and also adds a
missing parameter from the `kubectl cp` example at the end of the page.

Issue reported by Fabrizio Fiorucci, as it can cause confusion and
possible error for a reader following along and reading the NAP
documentation concurrently.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jakub Jarosz <[email protected]>
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Jan 23, 2025
@nginx-bot nginx-bot requested review from a team as code owners January 23, 2025 16:26
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7201/

@vepatel vepatel changed the title [cherry-pick] Fix mountPath directory for NAP5 policy documentation Fix mountPath directory for NAP5 policy documentation Jan 23, 2025
@vepatel vepatel merged commit f3490e5 into release-4.0 Jan 23, 2025
23 checks passed
@vepatel vepatel deleted the cherry-pick-release-4.0-ae73e34914a42e340a3bdd5eaeec4248517afc63 branch January 23, 2025 16:41
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants