Skip to content

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 16, 2024

Proposed changes

  • update build dependencies to nginx 1.27.1

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 16, 2024 10:21
@github-actions github-actions bot added the docker Pull requests that update Docker code label Aug 16, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.89%. Comparing base (491e68e) to head (768fae4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6224      +/-   ##
==========================================
+ Coverage   45.58%   45.89%   +0.30%     
==========================================
  Files         142      142              
  Lines       18961    18961              
==========================================
+ Hits         8644     8702      +58     
+ Misses       9868     9814      -54     
+ Partials      449      445       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Aug 16, 2024
@jjngx jjngx merged commit edd0b17 into main Aug 16, 2024
80 checks passed
@jjngx jjngx deleted the nginx-deps branch August 16, 2024 12:36
@pdabelf5 pdabelf5 added dependencies Pull requests that update a dependency file and removed docker Pull requests that update Docker code labels Sep 23, 2024
@pdabelf5 pdabelf5 changed the title update nic build dependencies to nginx 1.27.1 Update nic build dependencies to nginx 1.27.1 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants