Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/python clean up, and unused variable check to pre commit #5866

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Chore/python clean up, and unused variable check to pre commit #5866

merged 9 commits into from
Jun 26, 2024

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jun 26, 2024 •
edited
Loading

Proposed changes

  • removed an obscured function
  • adding pre commit tooling to error on unused imports/ unused variables.
  • autopep8 format

@j1m-ryan j1m-ryan requested a review from a team as a code owner June 26, 2024 12:51
@github-actions github-actions bot added python Pull requests that update Python code chore Pull requests for routine tasks tests Pull requests that update tests labels Jun 26, 2024
@j1m-ryan j1m-ryan force-pushed the chore/python-clean-up branch from 9fe87dd to c6d7e88 Compare June 26, 2024 13:00
@j1m-ryan j1m-ryan merged commit 21e29e5 into main Jun 26, 2024
80 checks passed
@j1m-ryan j1m-ryan deleted the chore/python-clean-up branch June 26, 2024 15:35
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@AlexFenlon
Chore/python clean up, and unused variable check to pre commit (#5866)
9591864 
* delete obscured function

* autopep8

* remove unsed imports

* remove unused variables

* add autoflake

* fix pre commit

* remove used vars via pre commit

* remove unused variables and presumably pure function calls

* remove unused calls
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 left review comments

@haywoodsh haywoodsh haywoodsh approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j1m-ryan @haywoodsh @jjngx @pdabelf5