Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove includeYear flag #5776

Closed
j1m-ryan opened this issue Jun 18, 2024 · 2 comments
Closed

Remove includeYear flag #5776

j1m-ryan opened this issue Jun 18, 2024 · 2 comments
Assignees
@harsha-mangena
Labels
chore Pull requests for routine tasks good first issue Issues identified as good for first-time contributors
Milestone
v3.7.0

Comments

@j1m-ryan
Copy link

j1m-ryan commented Jun 18, 2024 •
edited
Loading

Remove depcrecated include-year flag, and corresponding includeYear helm value
@j1m-ryan j1m-ryan added the chore Pull requests for routine tasks label Jun 18, 2024
@j1m-ryan j1m-ryan added this to the v3.7.0 milestone Jun 18, 2024
@j1m-ryan j1m-ryan added the good first issue Issues identified as good for first-time contributors label Jun 18, 2024
@harsha-mangena
Copy link
Contributor

Hey @j1m-ryan, Can I pick this issue.

@jjngx
Copy link
Contributor

jjngx commented Jun 18, 2024

@harsha-mangena please go ahead. If you have any questions please contact us.

harsha-mangena added a commit to harsha-mangena/kubernetes-ingress that referenced this issue Jun 21, 2024
@harsha-mangena
- refer nginx#5776
6c91606 
- commented deprecated include-year and IncludeYear
@harsha-mangena harsha-mangena mentioned this issue Jun 21, 2024
Merged
6 tasks
@vepatel vepatel mentioned this issue Jun 24, 2024
Open
This was referenced Jun 27, 2024
Closed
Closed
j1m-ryan pushed a commit that referenced this issue Jun 27, 2024
@harsha-mangena
[removes] include-year and includeYear flag (#5817)
a991a93 
* - refer #5776
- commented deprecated include-year and IncludeYear

* removed commented code

* - made `includeYear` flag as `true` by default.
- removed commented code.

* - addressed comments

* recommit - yaml

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

---------

Signed-off-by: harsha-mangena <[email protected]>
Co-authored-by: Jim Ryan <[email protected]>
AlexFenlon pushed a commit that referenced this issue Jul 1, 2024
@harsha-mangena @AlexFenlon
[removes] include-year and includeYear flag (#5817)
d15d12b 
* - refer #5776
- commented deprecated include-year and IncludeYear

* removed commented code

* - made `includeYear` flag as `true` by default.
- removed commented code.

* - addressed comments

* recommit - yaml

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

* removed include-year arg

Signed-off-by: harsha-mangena <[email protected]>

---------

Signed-off-by: harsha-mangena <[email protected]>
Co-authored-by: Jim Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harsha-mangena harsha-mangena

Labels
chore Pull requests for routine tasks good first issue Issues identified as good for first-time contributors
Projects
None yet
Milestone
v3.7.0
Development

No branches or pull requests
3 participants
@j1m-ryan @harsha-mangena @jjngx