Skip to content

Rename banner param to nd-banner #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Rename banner param to nd-banner #732

merged 2 commits into from
Jun 24, 2025

Conversation

@lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Jun 23, 2025 •
edited
Loading

Proposed changes

Renamed param banner to be nd-banner to prevent any potential collisions with built-in Hugo params.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Jun 23, 2025
@lamATnginx lamATnginx requested review from a team as code owners June 23, 2025 15:14
@lamATnginx lamATnginx changed the title chore: rename banner param to nd-banner Rename banner param to nd-banner Jun 23, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager product/ngf Issues related to NGINX Gateway Fabric product/agent Issues related to NGINX Agent product/controller Issues related to NGINX Controller (EOS product) product/mesh Issues related to NGINX Service Mesh (EOS product) labels Jun 23, 2025
@github-actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/732/

@lamATnginx lamATnginx mentioned this pull request Jun 23, 2025
Merged
4 tasks
@ADubhlaoich ADubhlaoich merged commit f205c7c into main Jun 24, 2025
10 checks passed
@ADubhlaoich ADubhlaoich deleted the banner-rename branch June 24, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@travisamartin travisamartin travisamartin approved these changes

Assignees

@lamATnginx lamATnginx

Labels

documentation Improvements or additions to documentation product/agent Issues related to NGINX Agent product/controller Issues related to NGINX Controller (EOS product) product/mesh Issues related to NGINX Service Mesh (EOS product) product/ngf Issues related to NGINX Gateway Fabric product/nim Issues related to NGINX Instance Manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lamATnginx @ADubhlaoich @travisamartin