fixing keepalived dependency for offline installation(NIM)#233
Merged
mjang merged 10 commits intonginx:mainfrom Feb 27, 2025
Merged
fixing keepalived dependency for offline installation(NIM)#233mjang merged 10 commits intonginx:mainfrom
mjang merged 10 commits intonginx:mainfrom
Conversation
ADubhlaoich
approved these changes
Feb 27, 2025
mjang
approved these changes
Feb 27, 2025
Contributor
mjang
left a comment
There was a problem hiding this comment.
I'm going to push minor text changes to the messages shown to users, and will then merge.
mjang
approved these changes
Feb 27, 2025
Contributor
|
@bejjrajesh One comment -- I see you used "please" when telling the user to install Docker. In most cases, we wouldn't use "please," as it's sort of a waste of space. But in this particular case, it's appropriate. Nice work! Per Google guidelines (material.io is essentially a Google style guide), |
10 tasks
JTorreG
added a commit
that referenced
this pull request
Oct 9, 2025
docs: add certs overview page for NGINXaaS for Google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NIM 2.19.0 introduced a dependency on keepalived. For online installations, this dependency is getting auto resolved and installed. But offline installations are not packaging keepalived and it's dependencies in the final tar.gz archive file.
Solution: This MR contains the changes to include keepalived and it's dependencies in the zip archive created in the offline mode installation.
Testing: Manual testing performed on ubuntu and rpm based systems.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.mdandCHANGELOG.mdFootnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩