Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check version command output #853

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Check version command output #853

merged 11 commits into from
Sep 23, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 18, 2024 •
edited
Loading

Proposed changes

Add test in integration tests to check the output of the nginx-agent --version contains the correct format nginx-agent version v<version number>-<build number>

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 18, 2024
@aphralG aphralG requested a review from a team September 19, 2024 09:59
@aphralG aphralG marked this pull request as ready for review September 19, 2024 09:59
@aphralG aphralG changed the title Draft: Check version command output Check version command output Sep 19, 2024
@aphralG aphralG self-assigned this Sep 19, 2024
@aphralG aphralG added the v2.x Issues and Pull Requests related to the major version v2 label Sep 19, 2024
@oliveromahony oliveromahony requested a review from a team September 23, 2024 12:55
@aphralG aphralG merged commit dc3f8f5 into main Sep 23, 2024
37 checks passed
@aphralG aphralG deleted the add-version-check-test branch September 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CVanF5 CVanF5 CVanF5 approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @dhurley @craigell @CVanF5