Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove official docker images & move testing images to test folder #838

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 12, 2024

Proposed changes

Removed official docker images from scripts folder
Moved test images from scripts folder to test folder
Removed official docker image make targets

Should be merged after #827

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link
Contributor

github-actions bot commented Sep 12, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@aphralG
Copy link
Contributor Author

aphralG commented Sep 12, 2024

I have hereby read the F5 CLA and agree to its terms

@oliveromahony
Copy link
Contributor

@nginx-seanmoloney do we need a release note for this?

@oliveromahony oliveromahony added highlights Highlights label to be placed in highlights section for a particular release v2.x Issues and Pull Requests related to the major version v2 labels Sep 12, 2024
@aphralG aphralG merged commit b88ad83 into main Sep 17, 2024
37 checks passed
@aphralG aphralG deleted the remove-old-official-images branch September 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highlights Highlights label to be placed in highlights section for a particular release v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants