Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty metric reports #82

Merged
merged 19 commits into from
Nov 3, 2022
Merged

Fix empty metric reports #82

merged 19 commits into from
Nov 3, 2022

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Oct 21, 2022

Proposed changes

Setting defaults for advanced metrics flags caused empty metric reports to be sent.

  • Remove defaults from advanced metrics flags
  • Reduce log level of "Error getting default network interface"
  • Clean up comms.go
  • Check if report is empty before metrics report is sent

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@aphralG aphralG self-assigned this Oct 21, 2022
@github-actions github-actions bot added bug Something isn't working dependencies labels Oct 21, 2022
dhurley
dhurley reviewed Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have 2 minor comments

src/plugins/comms.go Outdated Show resolved Hide resolved
src/plugins/comms.go Outdated Show resolved Hide resolved
Dean-Coakley
Dean-Coakley approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

sanathkumarbs
sanathkumarbs approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

src/core/network/network.go Show resolved Hide resolved
src/plugins/metrics_throlling.go Outdated Show resolved Hide resolved
src/core/config/defaults.go Show resolved Hide resolved
src/plugins/comms.go Outdated Show resolved Hide resolved
src/plugins/metrics_throlling.go Outdated Show resolved Hide resolved
src/plugins/comms_test.go Show resolved Hide resolved
@sanathkumarbs
Copy link
Contributor

Likely should close #79 as we this PR.

@sanathkumarbs sanathkumarbs mentioned this pull request Oct 26, 2022
Closed
4 tasks
@aphralG aphralG merged commit 29a7d1d into main Nov 3, 2022
@oliveromahony oliveromahony deleted the fix-empty-metric-reports branch November 21, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@nickchen nickchen nickchen left review comments

@sanathkumarbs sanathkumarbs sanathkumarbs approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell craigell approved these changes

Assignees

@aphralG aphralG

Labels
bug Something isn't working dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aphralG @sanathkumarbs @oliveromahony @nickchen @dhurley @Dean-Coakley @craigell