Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix name of deprecated flag #811

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix name of deprecated flag #811

merged 1 commit into from
Aug 30, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Aug 29, 2024 •
edited
Loading

Proposed changes

Fix name for deprecated flag to remove warning from logs

Before:

nginx-agent -v
WARN[0000] Error occurred deprecating flag metrics-bulksize: flag "metrics-bulksize" does not exist

After

nginx-agent -v
nginx-agent version v2.37.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Aug 29, 2024
@aphralG aphralG merged commit 196ac3f into main Aug 30, 2024
38 checks passed
@aphralG aphralG deleted the fix-deprecated-flag branch August 30, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@CVanF5 CVanF5 Awaiting requested review from CVanF5

@sean-breen sean-breen Awaiting requested review from sean-breen

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aphralG @dhurley @craigell