Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post install script for when no nginx instance is installed #773

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix post install script for when no nginx instance is installed #773

merged 1 commit into from
Aug 7, 2024

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Aug 7, 2024

Proposed changes

Fix post install script for when no nginx instance is installed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Aug 7, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 7, 2024
@dhurley dhurley merged commit ef9524a into main Aug 7, 2024
28 checks passed
@dhurley dhurley deleted the fix-post-install-script branch August 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@craigell craigell Awaiting requested review from craigell

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees

@dhurley dhurley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhurley @oliveromahony @aphralG