Add new docker images to v2 pipeline for integration testing #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove whitespace
dhurley
approved these changes
Aug 7, 2024
aphralG
changed the title
dhurley
approved these changes
Aug 13, 2024
.github/workflows/ci.yml
Outdated
| @@ -160,11 +212,17 @@ jobs: | |||
| with: | |||
| name: nginx-agent-unsigned-snapshots | |||
| path: build | |||
| - name: Login to Docker Registry | |||
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 | |||
There was a problem hiding this comment.
Suggested change
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 | |
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0 |
| @@ -176,7 +234,7 @@ jobs: | |||
| if: success() || failure() | |||
| uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | |||
| with: | |||
| name: integration-test-logs-${{ matrix.container.image }}-${{ matrix.container.version }} | |||
| name: integration-test-logs-${{ matrix.container.image }}-${{ matrix.container.version }}-new | |||
There was a problem hiding this comment.
Suggested change
| name: integration-test-logs-${{ matrix.container.image }}-${{ matrix.container.version }}-new | |
| name: integration-test-official-images-logs-${{ matrix.container.image }}-${{ matrix.container.version }} |
aphralG
approved these changes
Aug 16, 2024
aphralG
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add new docker images from docker registry to the integration testing job
Removed
docker-compose-apk.ymldocker-compose-rpm.ymldocker-compose-deb.ymlin api, features, grpc and install integration tests replaced withdocker-compose.ymlChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)