Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backoff to drop Metrics Reports from buffer after max_elapsed_time has been reached #752

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Fix backoff to drop Metrics Reports from buffer after max_elapsed_time has been reached #752

merged 5 commits into from
Jul 24, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

added metrics backoff settings so they are different from the command backoff. This allows us to set the max_elapsed_time to something not 0 that would drop metrics from the buffer after that timeout period

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Jul 17, 2024
@oliveromahony oliveromahony changed the title Fix backoff to drop buffer after max_elapsed_time has elapsed Fix backoff to drop Metrics Reports from buffer after max_elapsed_time has been reached Jul 17, 2024
@oliveromahony oliveromahony merged commit db3cd8d into main Jul 24, 2024
28 checks passed
@oliveromahony oliveromahony deleted the fix-backoff-to-drop-buffer branch July 24, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@olli-holmala olli-holmala olli-holmala approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliveromahony @craigell @olli-holmala @aphralG