Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add deduplication for the same ssl cert metadata #716

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix: add deduplication for the same ssl cert metadata #716

merged 4 commits into from
Jun 24, 2024

Conversation

mattdesmarais
Copy link
Collaborator

Proposed changes

Add deduplication for ssl certificate metadata. This handles the case where the same ssl certificates are being used many times throughout the nginx.conf.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Jun 20, 2024
mattdesmarais
mattdesmarais commented Jun 24, 2024
View reviewed changes
Copy link
Collaborator Author

@mattdesmarais mattdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @oliveromahony

@oliveromahony oliveromahony merged commit c150b56 into nginx:main Jun 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattdesmarais @dhurley @craigell @aphralG @oliveromahony