Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto updates #68

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Proto updates #68

merged 2 commits into from
Oct 11, 2022

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Updated the protos for future scenarios

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

Copy link
Contributor

@nickchen nickchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i wonder if we should comment the deprecated field above the field instead of in the same line, that way it'll show as comment addition instead of add/remove.

@oliveromahony oliveromahony merged commit 9328081 into main Oct 11, 2022
@oliveromahony oliveromahony deleted the enhanced_protos branch October 11, 2022 11:23
mohamed-gougam pushed a commit that referenced this pull request Oct 11, 2022
* Proto updates for future workflows

Co-authored-by: o.omahony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants