-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health check endpoint #665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
requested review from
oliveromahony,
Dean-Coakley,
craigell,
olli-holmala,
spencerugbo and
aphralG
May 7, 2024 10:21
✅ Deploy Preview for agent-public-docs canceled.
|
olli-holmala
reviewed
May 7, 2024
olli-holmala
reviewed
May 7, 2024
Comment on lines
+698
to
+699
registrationStatus = errorStatus | ||
overallStatus = errorStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these could potentially be simplified to one line.
Suggested change
registrationStatus = errorStatus | |
overallStatus = errorStatus | |
registrationStatus, overallStatus = errorStatus, errorStatus |
olli-holmala
approved these changes
May 7, 2024
Dean-Coakley
approved these changes
May 7, 2024
oliveromahony
approved these changes
May 8, 2024
dhurley
added
the
highlights
Highlights label to be placed in highlights section for a particular release
label
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
dependencies
highlights
Highlights label to be placed in highlights section for a particular release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Example response:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)