Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check endpoint #665

Merged
merged 11 commits into from
May 8, 2024
Merged

Add health check endpoint #665

merged 11 commits into from
May 8, 2024

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented May 7, 2024

Proposed changes

Example response:

{
  "status": "ERROR",
  "checks": [
    {
      "name": "registration",
      "status": "OK"
    },
    {
      "name": "commandConnection",
      "status": "OK"
    },
    {
      "name": "metricsConnection",
      "status": "ERROR"
    }
  ]
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this May 7, 2024
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9841742
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/663b41c2c77f410008eed74f

docs/swagger.json Outdated Show resolved Hide resolved
Comment on lines +698 to +699
registrationStatus = errorStatus
overallStatus = errorStatus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these could potentially be simplified to one line.

Suggested change
registrationStatus = errorStatus
overallStatus = errorStatus
registrationStatus, overallStatus = errorStatus, errorStatus

@dhurley dhurley merged commit 24d8ad1 into main May 8, 2024
33 checks passed
@dhurley dhurley deleted the add-health-check-endpoint branch May 8, 2024 13:33
@dhurley dhurley added the highlights Highlights label to be placed in highlights section for a particular release label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies highlights Highlights label to be placed in highlights section for a particular release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants