Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close all open file descriptors #66

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix close all open file descriptors #66

merged 1 commit into from
Oct 11, 2022

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Close trailing file descriptors to release resources more reliably

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley Dean-Coakley self-assigned this Oct 7, 2022
@github-actions github-actions bot added bug Something isn't working dependencies labels Oct 7, 2022
dhurley
dhurley reviewed Oct 10, 2022
View reviewed changes
sdk/config_apply.go Show resolved Hide resolved
sdk/config_apply.go Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit 9888ac0 into main Oct 11, 2022
@Dean-Coakley Dean-Coakley deleted the fix-leaking-fds branch October 11, 2022 09:30
mohamed-gougam pushed a commit that referenced this pull request Oct 11, 2022
@Dean-Coakley
Fix close leaking file descriptors (#66)
caa7a71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

Assignees

@Dean-Coakley Dean-Coakley

Labels
bug Something isn't working dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @dhurley @aphralG