Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test #607

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix unit test #607

merged 3 commits into from
Mar 20, 2024

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Fix failing unit test by mocking IsContainer properly

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 002c31f
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65fafa1b2d1f88000855c36e

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.21%. Comparing base (808c064) to head (599c253).
Report is 6 commits behind head on main.

Files Patch % Lines
src/core/environment.go 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   66.13%   66.21%   +0.08%     
==========================================
  Files         118      118              
  Lines       13485    13471      -14     
==========================================
+ Hits         8918     8920       +2     
+ Misses       3963     3952      -11     
+ Partials      604      599       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/environment.go Outdated Show resolved Hide resolved
@oliveromahony oliveromahony merged commit 95bdf44 into main Mar 20, 2024
29 checks passed
@oliveromahony oliveromahony deleted the fix-failing-tests branch March 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants