Add logging to NGINX API http requests #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
requested review from
oliveromahony,
Dean-Coakley,
craigell,
olli-holmala,
spencerugbo and
aphralG
✅ Deploy Preview for agent-public-docs canceled.
|
| return false | ||
| } | ||
|
|
||
| // Expecting API to return the api versions in an array of positive integers | ||
| // subset example: [ ... 6,7,8,9 ...] | ||
| var responseBody []int | ||
| err = json.Unmarshal(bodyBytes, &responseBody) | ||
| if err != nil { | ||
| log.Debugf("Unable to unmarshal NGINX Plus API response body: %v", err) |
sdk/config_helpers.go
Outdated
| return false | ||
| } | ||
|
|
||
| bodyBytes, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| log.Debugf("Unable to read Stub Status API response body: %v", err) |
sdk/config_helpers.go
Outdated
| resp, err := client.Get(statusAPI) | ||
| if err != nil { | ||
| log.Debugf("Unable to create client for Stub Status API request: %v", err) |
olli-holmala
approved these changes
Mar 20, 2024
oliveromahony
approved these changes
Mar 20, 2024
aphralG
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)