Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Support for NAP 5 #604

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat: Add Support for NAP 5 #604

merged 1 commit into from
Mar 25, 2024

Conversation

edarzins
Copy link
Contributor

Added ability to recognize and report NAP 5.0 installation

Proposed changes

This updates the agent to recognize a NAP 5 installation and to report new info via the DataplaneSoftwareDetails message.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@edarzins
feat: Add Support for NAP 5
d167b63 
Added ability to recognize and report NAP 5.0 installation
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation enhancement New feature or request labels Mar 18, 2024
@oliveromahony oliveromahony merged commit b6177d6 into nginx:main Mar 25, 2024
25 checks passed
@oliveromahony oliveromahony added the highlights Highlights label to be placed in highlights section for a particular release label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

@craigell craigell Awaiting requested review from craigell

@olli-holmala olli-holmala Awaiting requested review from olli-holmala

@spencerugbo spencerugbo Awaiting requested review from spencerugbo

@aphralG aphralG Awaiting requested review from aphralG

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation enhancement New feature or request highlights Highlights label to be placed in highlights section for a particular release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edarzins @oliveromahony @dhurley