Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add additional container checks during instance registration #592

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: add additional container checks during instance registration #592

merged 1 commit into from
Mar 13, 2024

Conversation

mattdesmarais
Copy link
Collaborator

@mattdesmarais mattdesmarais commented Mar 8, 2024 •
edited by oliveromahony
Loading

Proposed changes

  • Add additional check to detect non-docker container runtime during instance registration
  • This function is a duplicate function and will be removed in a future release

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 8, 2024
@mattdesmarais mattdesmarais changed the title wip: add additional container checks during instance registration fix: add additional container checks during instance registration Mar 12, 2024
@mattdesmarais mattdesmarais marked this pull request as ready for review March 12, 2024 19:56
@oliveromahony oliveromahony added the documentation Improvements or additions to documentation label Mar 13, 2024
@oliveromahony oliveromahony merged commit 808c064 into nginx:main Mar 13, 2024
25 checks passed
@oliveromahony oliveromahony added the highlights Highlights label to be placed in highlights section for a particular release label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation highlights Highlights label to be placed in highlights section for a particular release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattdesmarais @oliveromahony @dhurley