Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore agent container information from nms docs #584

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Mar 1, 2024

Proposed changes

The information in this doc was originally added to the NMS docs, in the agent section, in PR 210 in the docs repo.

I have made an effort to ensure the information provided here aligns with the current state of the Makefile in the repo.

Please verify that the supported distributions listed for OSS and Plus are correct, and that the location where the crt and key files should be saved is correct.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 1, 2024
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 19b26d0
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65e11d9efeca450009845922
😎 Deploy Preview https://deploy-preview-584--agent-public-docs.netlify.app/nginx-agent/installation-upgrade/container-environments/docker-images
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jputrino jputrino requested a review from mtbChef March 1, 2024 00:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.12%. Comparing base (82c7a23) to head (19b26d0).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         118      118           
  Lines       13461    13461           
=======================================
  Hits         8901     8901           
  Misses       3959     3959           
  Partials      601      601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtbChef mtbChef requested a review from ninaforsyth March 1, 2024 00:28
Copy link

@ninaforsyth ninaforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@mtbChef mtbChef merged commit 14a8f18 into main Mar 1, 2024
13 of 29 checks passed
@mtbChef mtbChef deleted the docs-agent-container-jp branch March 1, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants