Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact name #558

Merged
merged 18 commits into from
Feb 6, 2024
Merged

Fix artifact name #558

merged 18 commits into from
Feb 6, 2024

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Feb 1, 2024

Proposed changes

Changed naming of artifact uploads from nginx-agent-snapshots to nginx-agent-unsigned-snapshots and nginx-agent-signed-snapshots

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit b75fee9
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65c23ab4e8eb8700088af652
😎 Deploy Preview https://deploy-preview-558--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Feb 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5efc8c2) 66.00% compared to head (8e82a38) 66.14%.
Report is 5 commits behind head on main.

❗ Current head 8e82a38 differs from pull request most recent head a584fd6. Consider uploading reports for the commit a584fd6 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   66.00%   66.14%   +0.14%     
==========================================
  Files         118      118              
  Lines       13468    13461       -7     
==========================================
+ Hits         8889     8904      +15     
+ Misses       3979     3956      -23     
- Partials      600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olli-holmala
Copy link
Contributor

Does this mean that there was a name collision?

image

@aphralG aphralG merged commit c3bd562 into main Feb 6, 2024
29 checks passed
@aphralG aphralG deleted the fix-artifact-name branch February 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants