Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runners and bump go version #550

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jan 31, 2024

Proposed changes

Bump versions to remove warnings like: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: action For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

golangci-lint action still does not have node 20, can pin to a specific commit or wait for a new release golangci/golangci-lint-action#953

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit e11f314
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65bbb09dd36edc00084a0efb

@github-actions github-actions bot added bug Something isn't working dependencies labels Jan 31, 2024
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5efc8c2) 66.00% compared to head (8e86196) 66.12%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   66.00%   66.12%   +0.12%     
==========================================
  Files         118      118              
  Lines       13468    13461       -7     
==========================================
+ Hits         8889     8901      +12     
+ Misses       3979     3959      -20     
- Partials      600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony marked this pull request as ready for review February 1, 2024 16:41
@oliveromahony
Copy link
Contributor Author

golangci-lint action still does not have node 20, can pin to a specific commit or wait for a new release golangci/golangci-lint-action#953

@oliveromahony oliveromahony merged commit 71ae09c into main Feb 1, 2024
29 checks passed
@oliveromahony oliveromahony deleted the fix-runners-github-actions branch February 1, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants