Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict NAP file/dir permissions #516

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Nov 16, 2023

Proposed changes

  • Restrict permissions of NAP directories and files
  • Improve error handling of NAP extension
  • Lint

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 416cd22
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65564adfe39634000814eb70

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Nov 16, 2023
@Dean-Coakley Dean-Coakley marked this pull request as draft November 16, 2023 15:00
@Dean-Coakley Dean-Coakley marked this pull request as ready for review November 16, 2023 15:27
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0854fe6) 66.14% compared to head (416cd22) 66.11%.

Files Patch % Lines
...c/extensions/nginx-app-protect/nap/nap_metadata.go 46.15% 6 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   66.14%   66.11%   -0.03%     
==========================================
  Files         118      118              
  Lines       13462    13468       +6     
==========================================
+ Hits         8904     8905       +1     
- Misses       3957     3963       +6     
+ Partials      601      600       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dean-Coakley Dean-Coakley merged commit 63943e9 into main Dec 6, 2023
28 checks passed
@Dean-Coakley Dean-Coakley deleted the restrict-nap-file-permissions branch December 6, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants