Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error log causing failures #488

Merged
merged 2 commits into from
Sep 26, 2023
Merged

remove error log causing failures #488

merged 2 commits into from
Sep 26, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 26, 2023

Proposed changes

Remove error causing pipelines to fail

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit e803407
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6513022d8104650008b86e9d

@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 26, 2023
@aphralG aphralG requested review from craigell and Dean-Coakley and removed request for Dean-Coakley September 26, 2023 16:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d75b51e) 66.40% compared to head (e803407) 66.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   66.40%   66.28%   -0.13%     
==========================================
  Files         118      118              
  Lines       13392    13382      -10     
==========================================
- Hits         8893     8870      -23     
- Misses       3907     3921      +14     
+ Partials      592      591       -1     
Files Coverage Δ
src/core/nginx.go 43.81% <ø> (+0.61%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony merged commit 394a3fe into main Sep 26, 2023
27 checks passed
@oliveromahony oliveromahony deleted the remove-error branch September 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants