Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate system.mem.used.all metric #485

Merged
merged 6 commits into from
Oct 3, 2023
Merged

deprecate system.mem.used.all metric #485

merged 6 commits into from
Oct 3, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 25, 2023

Proposed changes

Deprecate system.mem.used.all metric and remove system.mem.used.all from tests
Fixed system.mem.used to have the correct value

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit c6a86eb
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/651be85f114bca0008c66b5f
😎 Deploy Preview https://deploy-preview-485--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (df8cf6e) 66.29% compared to head (c6a86eb) 66.09%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   66.29%   66.09%   -0.21%     
==========================================
  Files         118      118              
  Lines       13441    13439       -2     
==========================================
- Hits         8911     8882      -29     
- Misses       3936     3964      +28     
+ Partials      594      593       -1     
Files Coverage Δ
...om/nginx/agent/v2/src/core/metrics/metrics_util.go 82.99% <ø> (-0.05%) ⬇️
...com/nginx/agent/v2/src/core/metrics/sources/mem.go 76.47% <100.00%> (-0.68%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aphralG aphralG changed the title fix memory metrics deprecate system.mem.used.all metric Oct 3, 2023
@aphralG aphralG merged commit f1a7a51 into main Oct 3, 2023
27 checks passed
@aphralG aphralG deleted the fix-memory-metrics branch October 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants