Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error log if duplicate NGINX IDs are found #477

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 18, 2023

Proposed changes

Add error log if duplicate NGINX IDs are found due to multiple NGINX instances running.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 8e012b9
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65081d821288340008fc368a

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.23% ⚠️

Comparison is base (556f51e) 66.44% compared to head (8e012b9) 66.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   66.44%   66.21%   -0.23%     
==========================================
  Files         118      118              
  Lines       13390    13400      +10     
==========================================
- Hits         8897     8873      -24     
- Misses       3903     3938      +35     
+ Partials      590      589       -1     
Files Changed Coverage Δ
src/core/nginx.go 43.19% <0.00%> (-0.62%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley merged commit 0dde035 into main Sep 21, 2023
28 checks passed
@dhurley dhurley deleted the add-log-for-duplicate-nginx-id branch September 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants