Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS upstream and TLS server_zone metrics #470

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Sep 11, 2023

Proposed changes

  • Add TLS upstream metrics
  • Add TLS server_zone metrics.
  • Fix unit test delta coverage

Note: R27+

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 76d224a
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6500828f3f92940008d15f8a

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch coverage: 79.54% and project coverage change: -0.47% ⚠️

Comparison is base (1e92813) 66.83% compared to head (76d224a) 66.36%.
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   66.83%   66.36%   -0.47%     
==========================================
  Files         113      118       +5     
  Lines       12931    13313     +382     
==========================================
+ Hits         8642     8835     +193     
- Misses       3719     3892     +173     
- Partials      570      586      +16     
Files Changed Coverage Δ
...or/github.com/nginx/agent/sdk/v2/config_helpers.go 64.19% <ø> (ø)
...nx/agent/v2/src/core/metrics/sources/nginx_plus.go 70.17% <76.31%> (-0.14%) ⬇️
...om/nginx/agent/v2/src/core/metrics/metrics_util.go 82.74% <100.00%> (+0.30%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dean-Coakley Dean-Coakley merged commit a9728fe into main Sep 12, 2023
@Dean-Coakley Dean-Coakley deleted the add-tls-metrics branch September 12, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants