Fix nginx-agent shutdown #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessWatcher waitgroup was already decremented in it's go routine so the wg.Done() in plugin.Close() led to panic due to negative waitgroup. This means on SIGTERM/SIGINT the main nginx-agent process would exit with status code 2 which is reported in systemd status.
Dean-Coakley
requested review from
oliveromahony,
dhurley,
craigell and
aphralG
ornj
reviewed
Sep 16, 2022
Dean-Coakley
force-pushed
the
fix-agent-shutdown
branch
from
d57a75c to
c0ea8f8
Compare
dhurley
approved these changes
Sep 20, 2022
|
@Dean-Coakley Can you run |
aphralG
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The ProcessWatcher waitgroup was already decremented in it's goroutine so the
wg.Done()inplugin.Close()led to panic due to negative waitgroup counter.This means on SIGTERM/SIGINT the main nginx-agent process would exit with status code 2 which is reported in
systemd status.Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)