-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ADM resource name dimensions #435
Conversation
✅ Deploy Preview for agent-public-docs canceled.
|
can you run |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 67.34% 67.33% -0.02%
==========================================
Files 113 113
Lines 12787 12793 +6
==========================================
+ Hits 8612 8614 +2
- Misses 3604 3609 +5
+ Partials 571 570 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an Analytics perspective, LGTM.
I would wait for Agent team members' reviews for feedback on implementation.
Proposed changes
Enhanced advanced metrics to accept new ADM resource name dimensions.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)