Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features missing defaults #43

Merged
merged 5 commits into from
Sep 9, 2022
Merged

features missing defaults #43

merged 5 commits into from
Sep 9, 2022

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Missed defaults

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added the enhancement New feature or request label Sep 9, 2022
@nickchen
Copy link
Contributor

nickchen commented Sep 9, 2022

works

@oliveromahony oliveromahony merged commit bcf7ef2 into main Sep 9, 2022
@oliveromahony oliveromahony deleted the defaults branch September 9, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickchen nickchen nickchen approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

@craigell craigell Awaiting requested review from craigell

@nkashiv nkashiv Awaiting requested review from nkashiv

@aphralG aphralG Awaiting requested review from aphralG

Assignees
No one assigned
Labels
dependencies enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliveromahony @nickchen