Change default REST api config #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-public-docs canceled.
|
oliveromahony
approved these changes
May 26, 2023
dhurley
approved these changes
May 26, 2023
jputrino
reviewed
May 31, 2023
nginx-agent.conf
Outdated
| @@ -38,4 +38,8 @@ config_dirs: "/etc/nginx:/usr/local/etc/nginx:/usr/share/nginx/modules:/etc/nms" | |||
|
|
|||
| api: | |||
| # default port for NGINX Agent API, this is for the server configuration of the REST API | |||
| port: 8081 | |||
| # port: 8081 | |||
There was a problem hiding this comment.
Is this the default port? Should we change this to a different suggestion, or leave it blank, to force users to define a different value?
jputrino
reviewed
May 31, 2023
Co-authored-by: Jodie Putrino <[email protected]>
jputrino
approved these changes
Jun 1, 2023
jputrino
reviewed
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating the default NGINX Agent config file to provide a warning of REST api port exposure and to comment out port by default
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)