Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change advanced metrics socket default location #32

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Sep 5, 2022

Proposed changes

  • Change default location of advanced metrics socket:/tmp/advanced-metrics.sock -> /var/run/nginx-agent/advanced-metrics.sock
  • Restrict socket permissions 0774 -> 0660

Validated that agent installed via package created socket that has a group of nginx-agent, with rw permissions:

$ ls -l /var/run/nginx-agent/
total 0
srw-rw---- 1 root nginx-agent 0 Sep  7 15:21 advanced-metrics.sock
srw-rw---- 1 root nginx-agent 0 Sep  7 15:21 nginx.sock

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added dependencies documentation Improvements or additions to documentation labels Sep 5, 2022
src/plugins/advanced_metrics.go Outdated Show resolved Hide resolved
src/extensions/advanced-metrics/reader/reader.go Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit d2761c8 into main Sep 8, 2022
@Dean-Coakley Dean-Coakley deleted the move-adv-socket branch September 8, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants