Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages scripts refactor #316

Merged
merged 3 commits into from
May 22, 2023
Merged

Packages scripts refactor #316

merged 3 commits into from
May 22, 2023

Conversation

oCHRISo
Copy link
Collaborator

@oCHRISo oCHRISo commented May 17, 2023 •
edited
Loading

Proposed changes

Removing 5 seconds sleep at install time (preinstall script)
Updated the use of the words unified agent and agent to NGINX Agent

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented May 17, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 93ddc32
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/646623ee0ad33e0008f6c942

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 17, 2023
djgilcrease
djgilcrease approved these changes May 19, 2023
View reviewed changes
Copy link

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oCHRISo oCHRISo merged commit cf4cc7f into main May 22, 2023
@oCHRISo oCHRISo deleted the package-scripts-refactor branch May 22, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oCHRISo @djgilcrease @dhurley @Dean-Coakley @craigell @aphralG