Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-crossplane version to 0.4.15 #304

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Conversation

dareste
Copy link
Contributor

@dareste dareste commented Apr 26, 2023

Proposed changes

This is a change to use the latest go-crossplane version in the agent (0.4.15). The version currently used (0.4.1) is detecting valid nginx configurations as wrong ones. For instance:

map "$hostname" $myvar {
    hostnames;
    host1.local 1;
    host2.local 2;
    default	3;
}

Crossplane 0.4.1 refuses this valid map with an invalid number of parameters error.

Checklist

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 35f8e84
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64494bba70474000095eb8d0

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Apr 26, 2023
@oliveromahony oliveromahony requested review from oliveromahony, aphralG, dhurley, Dean-Coakley and craigell and removed request for oliveromahony April 26, 2023 16:15
@oliveromahony oliveromahony merged commit 0cad24a into nginx:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants