Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_log, access_log tackle syslog (#185) #302

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Conversation

Retssaze
Copy link
Contributor

@Retssaze Retssaze commented Apr 23, 2023

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 23, 2023
@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 25a2bd6
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64832ad81302d50008630c88
😎 Deploy Preview https://deploy-preview-302--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Retssaze Retssaze marked this pull request as draft April 24, 2023 09:54
@Retssaze Retssaze marked this pull request as ready for review April 24, 2023 09:55
@oliveromahony
Copy link
Contributor

Thanks for the contribution @Retssaze - can you run a make deps and commit the changes there? Also if you could add a unit test for these scenarios, it would be fantastic

@oliveromahony
Copy link
Contributor

Also lint seems to be failing

@Retssaze
Copy link
Contributor Author

Retssaze commented May 2, 2023

Dear @olivermahony, thank you very much for your mail

make deps does not work

@Dean-Coakley
Copy link
Contributor

@Retssaze I think for make deps to work, you need to run make install-tools first. See https://github.com/nginx/agent#development-environment-setup for more details.

src/core/nginx.go Outdated Show resolved Hide resolved
@Dean-Coakley
Copy link
Contributor

@Retssaze Did you get a chance to try running make install-tools before running make deps? - If it's still broken can you share the output of the command?

If you can run make deps successfully and resolve the minor lint issues this should be good to merge.

@Retssaze
Copy link
Contributor Author

Retssaze commented May 27, 2023 via email

@oliveromahony
Copy link
Contributor

Updated outstanding items - ready to merge now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agent can not handle syslog entries for error_log and access_log in nginx configuration
5 participants