Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass correct variable for lscpu command to work #280

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

mrajagopal
Copy link
Contributor

@mrajagopal mrajagopal commented Apr 6, 2023

Proposed changes

  • The exec.Command() function was being passed an incorrect argument instead of the actual command to be executed
  • Ran go test from within src/core

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

* The exec.Command() function was being passed an incorrect argument instead of the actual command to be executed
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit d98d7b5
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/642e9c7948ea4b000869049a

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Apr 6, 2023
@dhurley
Copy link
Collaborator

dhurley commented Apr 6, 2023

Can you run make deps locally?

@mrajagopal
Copy link
Contributor Author

mrajagopal commented Apr 6, 2023

Can you run make deps locally?

Apologies for not mentioning that earlier.
make deps didn't report any errors.
Do you need anything specific from that output?

@dhurley
Copy link
Collaborator

dhurley commented Apr 6, 2023

Can you run make deps locally?

Apologies for not mentioning that earlier. make deps didn't report any errors. Do you need anything specific from that output?

make deps should have updated some files in the vendor folders. Can you check to see if there are any local changes made after running make deps, and if there are can you push those changes.

* commit vendor files updated following a make deps
@mrajagopal
Copy link
Contributor Author

make deps should have updated some files in the vendor folders. Can you check to see if there are any local changes made after running make deps, and if there are can you push those changes.

Done, indeed there was a change, something made me think it was a manual change of mine.
Thanks for setting me straight on the workflow.

@mrajagopal
Copy link
Contributor Author

mrajagopal commented Apr 6, 2023

I running make unit-test locally passes with Total code coverage: 70.5%.
Is the unit-test failure in the CI/CD transient?

@Dean-Coakley
Copy link
Contributor

Yeah don't worry about the flaking unit test. We are tracking fixing that: #259

@dhurley dhurley removed dependencies chore Pull requests for routine tasks labels Apr 11, 2023
@dhurley dhurley merged commit 36e36eb into nginx:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants