-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move agent-dynamic.conf to /var/lib/nginx-agent #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-public-docs canceled.
|
github-actions
bot
added
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
labels
Mar 27, 2023
aphralG
requested review from
Dean-Coakley,
craigell,
dhurley and
oliveromahony
March 28, 2023 08:57
oliveromahony
approved these changes
Mar 31, 2023
dhurley
approved these changes
Apr 3, 2023
Dean-Coakley
approved these changes
Apr 3, 2023
dhurley
approved these changes
Apr 14, 2023
Dean-Coakley
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me pending: #268 (comment)
craigell
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Move
agent-dynamic.conf
from/etc/nginx-agent
to/var/lib/nginx-agent
agent-dynamic.conf
is now at/var/lib/nginx-agent/agent-dynamic.conf
Remove
var/log/nginx-agent
,/var/lib/nginx-agent
&/etc/nginx-agent
and contents when agent is uninstalled/usr/local/etc/nginx-agent
,/var/log/nginx-agent
&/var/db/nginx-agent
and contents when agent is uninstalledCheck to see if
agent-dynamic.conf
is in old location, if it is create a symlink between the old file and the file in the new location.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)