Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky install/uninstall test #260

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Mar 16, 2023

Proposed changes

  • Install/uninstall test now uses a single context
  • Fix: Check for nginx install now checks inside container rather than host

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Testing

Passed 45 runs in a row on my VM 15 * matrix of rockylinux, almalinux, ubuntu(respectively):

Run 1 times
ok  	github.com/nginx/agent/test/integration/install	101.312s
ok  	github.com/nginx/agent/test/integration/install	94.418s
ok  	github.com/nginx/agent/test/integration/install	22.826s
Run 2 times
ok  	github.com/nginx/agent/test/integration/install	52.023s
ok  	github.com/nginx/agent/test/integration/install	33.253s
ok  	github.com/nginx/agent/test/integration/install	22.226s
Run 3 times
ok  	github.com/nginx/agent/test/integration/install	48.382s
ok  	github.com/nginx/agent/test/integration/install	31.949s
ok  	github.com/nginx/agent/test/integration/install	22.246s
Run 4 times
ok  	github.com/nginx/agent/test/integration/install	52.999s
ok  	github.com/nginx/agent/test/integration/install	36.730s
ok  	github.com/nginx/agent/test/integration/install	22.432s
Run 5 times
ok  	github.com/nginx/agent/test/integration/install	51.788s
ok  	github.com/nginx/agent/test/integration/install	34.334s
ok  	github.com/nginx/agent/test/integration/install	22.083s
Run 6 times
ok  	github.com/nginx/agent/test/integration/install	100.555s
ok  	github.com/nginx/agent/test/integration/install	92.552s
ok  	github.com/nginx/agent/test/integration/install	22.608s
Run 7 times
ok  	github.com/nginx/agent/test/integration/install	57.978s
ok  	github.com/nginx/agent/test/integration/install	35.227s
ok  	github.com/nginx/agent/test/integration/install	22.208s
Run 8 times
ok  	github.com/nginx/agent/test/integration/install	52.876s
ok  	github.com/nginx/agent/test/integration/install	34.402s
ok  	github.com/nginx/agent/test/integration/install	24.797s
Run 9 times
ok  	github.com/nginx/agent/test/integration/install	57.189s
ok  	github.com/nginx/agent/test/integration/install	32.628s
ok  	github.com/nginx/agent/test/integration/install	21.654s
Run 10 times
ok  	github.com/nginx/agent/test/integration/install	49.162s
ok  	github.com/nginx/agent/test/integration/install	36.552s
ok  	github.com/nginx/agent/test/integration/install	21.823s
Run 11 times
ok  	github.com/nginx/agent/test/integration/install	50.825s
ok  	github.com/nginx/agent/test/integration/install	31.728s
ok  	github.com/nginx/agent/test/integration/install	20.233s
Run 12 times
ok  	github.com/nginx/agent/test/integration/install	51.977s
ok  	github.com/nginx/agent/test/integration/install	29.588s
ok  	github.com/nginx/agent/test/integration/install	20.949s
Run 13 times
ok  	github.com/nginx/agent/test/integration/install	43.217s
ok  	github.com/nginx/agent/test/integration/install	29.618s
ok  	github.com/nginx/agent/test/integration/install	21.690s
Run 14 times
ok  	github.com/nginx/agent/test/integration/install	95.431s
ok  	github.com/nginx/agent/test/integration/install	90.997s
ok  	github.com/nginx/agent/test/integration/install	24.131s
Run 15 times
ok  	github.com/nginx/agent/test/integration/install	102.997s
ok  	github.com/nginx/agent/test/integration/install	93.495s
ok  	github.com/nginx/agent/test/integration/install	23.632s

@Dean-Coakley Dean-Coakley self-assigned this Mar 16, 2023
@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 185ef41
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64134659d8bd02000872bf9b

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Mar 16, 2023
@Dean-Coakley Dean-Coakley merged commit 9953651 into main Mar 21, 2023
@Dean-Coakley Dean-Coakley deleted the fix-install-test-flakes branch March 21, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants