Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check if there are any warnings in the NGINX config validation #257

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add check if there are any warnings in the NGINX config validation #257

merged 1 commit into from
Mar 23, 2023
+12 −4

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Mar 15, 2023 •
edited
Loading

Proposed changes

Add check if there are any warnings in the NGINX config validation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Mar 15, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Mar 15, 2023
@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 98a9f3d
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6411eb134297620008e436ce

@oliveromahony oliveromahony merged commit d5bc91f into main Mar 23, 2023
@oliveromahony oliveromahony deleted the add-config-apply-preflight-checks branch March 23, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhurley @oliveromahony @Dean-Coakley @aphralG