Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor NGINX logs for errors & NGINX worker processes after a NGINX reload #255

Merged
merged 28 commits into from
Apr 3, 2023
Merged

Monitor NGINX logs for errors & NGINX worker processes after a NGINX reload #255

merged 28 commits into from
Apr 3, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Mar 15, 2023 •
edited
Loading

Proposed changes

  • Monitor NGINX logs for errors after a NGINX reload
  • Check that all NGINX worker processes are still up after a NGINX reload

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit a8fd768
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/642aedf9dbff0c00081359f5

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Mar 15, 2023
@dhurley dhurley self-assigned this Mar 16, 2023
@oliveromahony
Pid drain check (#258)
a6e2854 
* wip: monitoring pids
Dean-Coakley
Dean-Coakley reviewed Mar 16, 2023
View reviewed changes
@dhurley dhurley changed the title Monitor NGINX logs for errors after a NGINX reload Monitor NGINX logs for errors & NGINX worker pids after a NGINX reload Mar 16, 2023
@dhurley dhurley changed the title Monitor NGINX logs for errors & NGINX worker pids after a NGINX reload Monitor NGINX logs for errors & NGINX worker processes after a NGINX reload Mar 16, 2023
@dhurley dhurley marked this pull request as draft March 16, 2023 12:35
@oliveromahony oliveromahony self-assigned this Mar 23, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 23, 2023
@oliveromahony oliveromahony marked this pull request as ready for review March 23, 2023 18:13
dhurley
dhurley commented Apr 3, 2023
View reviewed changes
@oliveromahony oliveromahony merged commit 983fa21 into main Apr 3, 2023
@oliveromahony oliveromahony deleted the monitor-nginx-logs-for-errors-after-a-nginx-reload branch April 3, 2023 15:31
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley left review comments

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

Assignees

@oliveromahony oliveromahony

@dhurley dhurley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhurley @oliveromahony @Dean-Coakley @craigell @aphralG