Add alternative ways to find nginx exe file path #240

dhurley · 2023-03-08T17:36:37Z

Proposed changes

Add alternative ways of finding the NGINX executable path.
Set NGINX worker process exe to be it's master process exe.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING document
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (README.md)

…nxWorkersMap to use pids instead of NginxDetails.

…CTL const to environment.go

…o it's master process exe

oliveromahony · 2023-03-09T16:17:18Z

src/core/environment.go

+		0,
+		0)
+	if err != 0 {
+		return buf, length, err


does buf, length need to be returned here?

dhurley added 2 commits March 8, 2023 14:03

Add alternative ways of finding the NGINX executbale path. Update ngi…

ab56416

…nxWorkersMap to use pids instead of NginxDetails.

Update dataplane status logic to ignore worker processes. Add SYS_SYS…

4c0879b

…CTL const to environment.go

dhurley requested review from oliveromahony, Dean-Coakley, craigell and aphralG March 8, 2023 17:36

dhurley self-assigned this Mar 8, 2023

github-actions bot added chore Pull requests for routine tasks dependencies labels Mar 8, 2023

dhurley mentioned this pull request Mar 8, 2023

Add an alternative way to find the NGINX executable #232

Closed

4 tasks

dhurley added 2 commits March 9, 2023 11:39

Clean up getExe function

ab3056f

Update Proccesses function to set the exe of a nginx worker process t…

cd5e5b4

…o it's master process exe

oliveromahony reviewed Mar 9, 2023

View reviewed changes

src/core/environment.go

0,

0)

if err != 0 {

return buf, length, err

Copy link

Contributor

oliveromahony Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does buf, length need to be returned here?

oliveromahony approved these changes Mar 9, 2023

View reviewed changes

Clean up logging

960fb84

dhurley merged commit 68b8334 into release-2.23.2 Mar 10, 2023

dhurley deleted the add-alternative-ways-to-find-nginx-exe-file-path branch March 10, 2023 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add alternative ways to find nginx exe file path #240

Add alternative ways to find nginx exe file path #240

dhurley commented Mar 8, 2023 •

edited

Loading

oliveromahony Mar 9, 2023

Add alternative ways to find nginx exe file path #240

Add alternative ways to find nginx exe file path #240

Conversation

dhurley commented Mar 8, 2023 • edited Loading

Proposed changes

Checklist

oliveromahony Mar 9, 2023

Choose a reason for hiding this comment

dhurley commented Mar 8, 2023 •

edited

Loading