Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertion for no error level logs in tests #220

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add assertion for no error level logs in tests #220

merged 3 commits into from
Feb 27, 2023

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add assertion that there are no logs at error level in integration tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley Dean-Coakley self-assigned this Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 8fe68bf
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63f8dd0ad910b2000844a45f

@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 24, 2023
@Dean-Coakley Dean-Coakley marked this pull request as ready for review February 24, 2023 16:32
@Dean-Coakley Dean-Coakley merged commit 23ac68e into main Feb 27, 2023
@Dean-Coakley Dean-Coakley deleted the add-integrationLog-test branch February 27, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @oliveromahony @dhurley @aphralG