Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plus upstream metrics #214

Merged
merged 10 commits into from
Mar 2, 2023
Merged

Add plus upstream metrics #214

merged 10 commits into from
Mar 2, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 22, 2023

Proposed changes

  • Added plus stream upstream response time metrics

    • plus.stream.upstream.peers.response.time.count
    • plus.stream.upstream.peers.response.time.max
    • plus.stream.upstream.peers.response.time.median
    • plus.stream.upstream.peers.response.time.pctl95
  • Added plus http upstream response time metrics

    • plus.http.upstream.peers.response.time.count
    • plus.http.upstream.peers.response.time.max
    • plus.http.upstream.peers.response.time.median
    • plus.http.upstream.peers.response.time.pctl95
  • Added plus upstream connect time metrics

    • plus.stream.upstream.connect_time.count
    • plus.stream.upstream.connect_time.max
    • plus.stream.upstream.connect_time.median
    • plus.stream.upstream.connect_time.pctl95
  • Added plus upstream header time metrics

    • plus.http.upstream.peers.header_time.count
    • plus.http.upstream.peers.header_time.max
    • plus.http.upstream.peers.header_time.median
    • plus.http.upstream.peers.header_time.pctl95
  • Added nginx.http.request.current to the nginx oss metrics

Closes

closes #228

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 3699772
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63ff5c7e1aaad7000883caa6

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Feb 22, 2023
@aphralG aphralG marked this pull request as draft February 22, 2023 10:55
@aphralG aphralG marked this pull request as ready for review February 22, 2023 11:25
@aphralG aphralG changed the title Add plus upstream response time metrics Add plus upstream metrics Feb 24, 2023
@aphralG aphralG merged commit a7d6b02 into main Mar 2, 2023
@aphralG aphralG deleted the add-plus-upstream-response-metrics branch March 2, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent not reporting nginx.http.request.current for Nignx OSS
3 participants