-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print NginxConfig in JSON format for debug and trace levels #210
Conversation
✅ Deploy Preview for agent-public-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Can you run |
@dhurley fatal: No names found, cannot describe anything. |
Hi @dareste, I think there are 2 things you need to do before running
These 2 things only need to be done the first time you start using the agent. Let me know if this resolves your issue. |
LGTM once vendor dir is updated: #210 (comment) |
make deps looks outdated, I'll do a separate PR for that |
Proposed changes
This PR changes the
log.traceF
andlog.debugF
function arguments in those cases where we log theNginxConfig
protobuf message. Instead of the raw message (which is harder to parse and read when doing troubleshooting), the JSON version of the object is now logged.Closes #209
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
)