Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rockylinux support #196

Merged
merged 32 commits into from
Feb 22, 2023
Merged

Add rockylinux support #196

merged 32 commits into from
Feb 22, 2023

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Feb 10, 2023 •
edited
Loading

Proposed changes

  • Add support for rocky linux packages
  • Extend integration test to support rockylinux base image
  • Extend api integration test to run on centos based OSes

TODO

  • Dockerfile/Makefile structure
  • Update CI to run integration tests on many base images

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Feb 10, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9ba41b4
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63f50a101531fb000875a580

@Dean-Coakley Dean-Coakley changed the title Add rocky support Add rockylinux support Feb 10, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 10, 2023
@Dean-Coakley Dean-Coakley marked this pull request as ready for review February 13, 2023 14:49
dhurley
dhurley reviewed Feb 13, 2023
View reviewed changes
dhurley
dhurley reviewed Feb 20, 2023
View reviewed changes
@Dean-Coakley Dean-Coakley merged commit ae36d73 into main Feb 22, 2023
@Dean-Coakley Dean-Coakley deleted the add-rocky-support branch February 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

Assignees

@Dean-Coakley Dean-Coakley

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @dhurley @craigell @aphralG