Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Dockerfile to Folder for OSS #182

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Move Dockerfile to Folder for OSS #182

merged 2 commits into from
Jan 26, 2023
+67 −10

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jan 24, 2023 •
edited
Loading

Proposed changes

Moved Dockerfile for integration tests from ./test/docker/integration/api => ./scripts/docker/nginx-oss/ubuntu

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 52c9e5f
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63d1094cc2406200089a31e7

@aphralG aphralG self-assigned this Jan 24, 2023
@aphralG aphralG changed the title Move Dockerfile for Integration Tests Move Dockerfile to Folder for OSS Jan 25, 2023
@aphralG aphralG requested a review from oliveromahony January 25, 2023 10:50
@aphralG aphralG merged commit 6a9745a into main Jan 26, 2023
@oliveromahony oliveromahony deleted the add-oss-dockerfile branch February 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @oliveromahony @dhurley @Dean-Coakley