Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle case when NAP metadata directory doesn't exist #179

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix: Handle case when NAP metadata directory doesn't exist #179

merged 1 commit into from
Jan 23, 2023

Conversation

edarzins
Copy link
Contributor

When writing NAP metadata, create the metadata directory if it doesn't exist.

Proposed changes

  • Create NAP metadata directory if it doesn't already exist
  • Expanded unit test to cover this case

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@edarzins
fix: Handle case when NAP metadata directory doesn't exist
fb2007d 
When writing NAP metadata, create the metadata directory if it doesn't exist.
@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit fb2007d
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63cac230f9357d000894962d

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Jan 20, 2023
@dhurley dhurley merged commit a0f380f into nginx:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edarzins @oliveromahony @dhurley